Attempt to simplify the token cache providers #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DO NOT MERGE Ideally we'd want the implementation of the token cache providers to be simplified. However this is not yet possible because the MSAL Abstract token cache provider contains a boolean telling if the token cache is an app or user token cache (so that the key can be computed). Ideally we'd want the ITokenCache to tell the application if it's an app token cache or a user token cache.
…member named IsApplicationTokenCache, brought by AzureAD/microsoft-authentication-library-for-dotnet#1448 cc: @bgavrilMS @jennyf19
jmprieur
commented
Oct 23, 2019
| @@ -57,6 +57,6 @@ | |||
| <PackageReference Include="Microsoft.AspNetCore.Authentication.AzureAD.UI" Version="2.2.0" /> | |||
| <PackageReference Include="Microsoft.AspNetCore.Authentication.AzureADB2C.UI" Version="2.2.0" /> | |||
| <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="2.2.0" /> | |||
| <PackageReference Include="Microsoft.Identity.Client" Version="4.3.1" /> | |||
| <PackageReference Include="Microsoft.Identity.Client" Version="4.5.1-internal20191022.1isappcache" /> | |||
There was a problem hiding this comment.
Experimental. Contains PR AzureAD/microsoft-authentication-library-for-dotnet#1448, which not yet merged
|
cc: @bgavrilMS @jennyf19 @henrik-me @kalyankrishna1 @TiagoBrenck : if you want the MSAL.NET bits that work for this PR, see the artifacts of this build |
jennyf19
reviewed
Oct 23, 2019
| @@ -111,13 +102,29 @@ protected virtual Task OnBeforeWriteAsync(TokenCacheNotificationArgs args) | |||
|
|
|||
| public async Task ClearAsync() | |||
| { | |||
| await RemoveKeyAsync(CacheKey).ConfigureAwait(false); | |||
| // This is here a user token cache | |||
There was a problem hiding this comment.
This is here a user token cache [](start = 15, length = 31)
nit. "This is a user token cache"
jennyf19
reviewed
Oct 23, 2019
| @@ -22,37 +20,6 @@ public static class SqlTokenCacheProviderExtension | |||
| public static IServiceCollection AddSqlTokenCaches( | |||
There was a problem hiding this comment.
nit: Can this be singular? All the others are singular (i think)...ex AddSqlTokenCache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE yet (until Expose IsApplicationTokenCache #1448) is released in MSAL.NET
Ideally we'd want the implementation of the token cache
providers to be simplified. This is not yet possible because the MSAL Abstract token cache provider contained a boolean telling if the token cache is an app or user token cache (so that the key
can be computed).
Now the TokenCacheEventArgs bring this boolean.
This PR simplifies the code a lot.